Reviewer's Guide

Adds a new periodic metric in the C++ Presto worker that reports process uptime in seconds, aligning with an existing Java worker metric for restart alerting.

Sequence diagram for worker uptime metric recording

sequenceDiagram
  participant PrestoServer
  participant PeriodicTaskManager
  participant UptimeTask
  participant MetricRegistry

  PrestoServer->>PeriodicTaskManager: addTask(worker_runtime_uptime_secs, interval=2_000_000)
  Note over PrestoServer,PeriodicTaskManager: Task captures start_ time from PrestoServer

  loop Every 2 seconds
    PeriodicTaskManager->>UptimeTask: invoke()
    UptimeTask->>UptimeTask: seconds = now() - start_
    UptimeTask->>MetricRegistry: RECORD_METRIC_VALUE(kCounterWorkerRuntimeUptimeSecs, seconds)
  end

Class diagram for uptime metric and counters

classDiagram
  class PrestoServer {
    - start_ std::chrono::steady_clock::time_point
    - periodicTaskManager_ PeriodicTaskManager*
    + addServerPeriodicTasks() void
  }

  class PeriodicTaskManager {
    + addTask(taskFunction, intervalMicros int64_t, name std::string) void
  }

  class Counters {
  }

  class MetricRegistry {
    + registerPrestoMetrics() void
    + DEFINE_METRIC(counterName, statType) void
    + RECORD_METRIC_VALUE(counterName, value) void
  }

  class WorkerRuntimeUptimeMetric {
    + kCounterWorkerRuntimeUptimeSecs folly::StringPiece
  }

  PrestoServer --> PeriodicTaskManager : uses
  PrestoServer --> WorkerRuntimeUptimeMetric : records
  WorkerRuntimeUptimeMetric --> MetricRegistry : defined_in

  MetricRegistry <|-- Counters

  %% Constants represented as static members
  class PartitionedOutputBufferMetrics {
    + kCounterPartitionedOutputBufferGetDataLatencyMs std::string_view
  }

  PartitionedOutputBufferMetrics --> MetricRegistry : defined_in
  WorkerRuntimeUptimeMetric --> PartitionedOutputBufferMetrics : similar_metric_group

File-Level Changes

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.